Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GRPC version 1 Classic client #563

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update to GRPC version 1 Classic client #563

merged 1 commit into from
Sep 26, 2023

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Sep 26, 2023

updates GRPC with the classic client to use the renamed/breaking GRPC changes from weaviate/weaviate#3576

@dirkkul dirkkul requested a review from a team as a code owner September 26, 2023 04:33
@codecov-commenter
Copy link

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (7528726) 94.75% compared to head (5d96c70) 93.99%.
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   94.75%   93.99%   -0.77%     
==========================================
  Files          70       73       +3     
  Lines        8492     8611     +119     
==========================================
+ Hits         8047     8094      +47     
- Misses        445      517      +72
Files Coverage Δ
integration/test_cluster.py 100.00% <100.00%> (ø)
weaviate/connect/authentication.py 96.15% <100.00%> (ø)
weaviate/embedded.py 92.05% <100.00%> (ø)
weaviate/gql/get.py 97.24% <100.00%> (ø)
weaviate/util.py 91.01% <100.00%> (ø)
weaviate/connect/connection.py 89.30% <60.00%> (ø)
weaviate_grpc/search_get_pb2.py 64.70% <64.70%> (ø)
weaviate_grpc/weaviate_pb2_grpc.py 59.45% <57.89%> (-3.70%) ⬇️
weaviate_grpc/base_pb2.py 47.82% <47.82%> (ø)
weaviate_grpc/batch_pb2.py 44.82% <44.82%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul changed the title Update to GRPC version 1 Update to GRPC version 1 Classic client Sep 26, 2023
@dirkkul dirkkul mentioned this pull request Sep 26, 2023
Merged
@tsmith023 tsmith023 merged commit 223adc0 into main Sep 26, 2023
@tsmith023 tsmith023 deleted the update_grpc_to_v1 branch September 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkkul @codecov-commenter @tsmith023